WIP: Rather than just root, I changed it to where any user would work. Example: logaa-ron #11

Draft
theissenm wants to merge 1 commits from any-user_fuctionally into master
Owner

Changed the logic from looking for logroot. It now looks for /^"log/
Then "log" is replaced with nothing and quotes are strip... That is set as the user_name.

Changed the logic from looking for logroot. It now looks for /^"log/ Then "log" is replaced with nothing and quotes are strip... That is set as the user_name.
theissenm added 1 commit 1 year ago
ajohnson requested review from ajohnson 1 year ago
ajohnson requested review from Developers 1 year ago
theissenm was assigned by ajohnson 1 year ago
ajohnson self-assigned this 1 year ago
Owner

I like the feature, but the code needs review. In the current state (commit 3fb2aa3135), I am getting some very strange multiline aliases created that weren't there previously, such as:
domain=$'root\nroot\nroot\nroot\nroot\nroot\nroot@1.1.1.1\n1.1.1.2\n1.1.2.3\n1.2.3.4\n2.3.4.5\n3.4.5.6'

I like the feature, but the code needs review. In the current state (commit 3fb2aa3135), I am getting some very strange multiline aliases created that weren't there previously, such as: `domain=$'root\nroot\nroot\nroot\nroot\nroot\nroot@1.1.1.1\n1.1.1.2\n1.1.2.3\n1.2.3.4\n2.3.4.5\n3.4.5.6'`
ajohnson changed title from Rather than just root, I changed it to where any user would work. Example: logaa-ron to WIP: Rather than just root, I changed it to where any user would work. Example: logaa-ron 1 year ago
Owner

It appears the failure is in the new if statement not matching logroot TXT records correctly.

While we're working on this feature, let's work on making it login[username] instead. It's just more self-descriptive that way. I'll handle putting in a check and warning for existing logroot records.

(Edit for formatting)

It appears the failure is in the new if statement not matching `logroot` TXT records correctly. While we're working on this feature, let's work on making it `login[username]` instead. It's just more self-descriptive that way. I'll handle putting in a check and warning for existing `logroot` records. (Edit for formatting)
Poster
Owner

Where are we at on this?

Where are we at on this?

Reviewers

ajohnson was requested for review 1 year ago
skyfall/Developers was requested for review 1 year ago
This pull request is marked as a work in progress.
Sign in to join this conversation.
No reviewers
skyfall/Developers
No Label
No Milestone
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: skyfall/tab-sorcery#11
Loading…
There is no content yet.